On Wed, May 3, 2023 at 9:25 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Mon, 1 May 2023 09:54:29 -0700 > Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > After redefining alloc_pages, all uses of that name are being replaced. > > Change the conflicting names to prevent preprocessor from replacing them > > when it's not intended. > > Note, every change log should have enough information in it to know why it > is being done. This says what the patch does, but does not fully explain > "why". It should never be assumed that one must read other patches to get > the context. A year from now, investigating git history, this may be the > only thing someone sees for why this change occurred. > > The "why" above is simply "prevent preprocessor from replacing them > when it's not intended". What does that mean? Thanks for the feedback, Steve. I'll make appropriate modifications to the description. > > -- Steve > > > > > > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx. >