On Mon, Apr 24, 2023 at 01:30:56PM +0100, Matthew Wilcox wrote: > On Mon, Apr 24, 2023 at 07:49:12AM +0200, Christoph Hellwig wrote: > > block_page_mkwrite_return is neither block nor mkwrite specific, and > > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > > errno_to_vmfault. > > Could you move it about 300 lines down and put it near vmf_error() > so we think about how to unify the two at some point? > > Perhaps it should better be called vmf_fs_error() for now since the > errnos it handles are the kind generated by filesystems. I'll look into unifying them for the next version.