Re: [PATCH 0/12] Per-bdi writeback flusher threads v7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > OK, I spotted the problem. If we fallback to the on-stack allocation in
> > > bdi_writeback_all(), then we do the wait for the work completion with
> > > the bdi_lock mutex held. This can deadlock with bdi_forker_task(), so if
> > > we require that to be invoked to make progress (happens if a thread
> > > needs to be restarted), then we have a deadlock on that mutex.

> > > I'll cook up a fix for this, but probably not before the morning.

> > Untested fix. I think it should work, but I haven't run it here yet.

> Thanks for your feedback and explanations. Will not be able to test the
> patch before the afternoon. Will then give feedback as soon as I can. Of
> course, I can also test a new fix or series if you send one in the
> morning, after your own testing.

Just ran a quick test with your fix applied and ran into the same
problem: manual sync stays in D state. I could capture SysRq-T, I am
attaching part of the output (which was very big and continuously
displaying).


Hope this helps,

-- 
Damien Wyart
?#ÔJsysrq_tí]Is+9r¾ûWð>ÑÑØÕá°öuNã?#&&*PX$?¸
I½Å¿ÞHµ?¤?ÕCö[ºtЫ'?¥?_~?5_W¬Z?ê7!cdÕ÷¯þ|ö«ÜùÍo«ÿ2?Íê?Æúßþí¯}yõ÷·?óPIõÿXýçêd?½{Ýø¿?/òWò?r¼äDDó|<¯·~ÿzn?f÷"9?2½Dʤ???ekÛ?´c³Þ?ýñøz8GyÌDy?`å)Ï-IòûͦéZ?	ôx?ª4Ðí?Ó×SrA?®@¥hA?Ø:	j??Ïf
Í!QJíðB¨R}÷>?_DHv[ÄÆ?Ϋ­??Ì?_ýÁ?³w+±?19ak?õ?<°qHíKs8z¿=?hÃë!¶¢u±. åÕ?ç???_?ó>	j?$êÌK?G??ðvTDýÁ°\´§ôÏù`^7¹gMxÝÙóz¿+ìÑâ¤'®¼íÒ³Æî·Û$?Cÿd?zÒÚ7²N_w¶yñ_Aÿz??Æ<w¤ÊZ¼?ï1ö¶9zãL?!7
;ò?ÁsÓ^wë/ÍéEm??ß¹íé	^e¿?®´Ø¾rf9O?üywJj??~?4ÁÐHÀeù?f?:6aül??E,Ì0&þøfL??MB¼?ÿrnü'¿0 ð*©B·J?Ùnâ»LR"@÷OÇø:¡m?ZôlcÁ¶ídÜÆpL??&J´"|?/?Ñ?ë¬vHøózòGÀu???í«+á|?³Þ^Ë??ëEqÒ?&?06?ÿäü§¤?iÐa¤hÝ®þ?þþ40òºÎòÂi·?¯Ã×ÆX-?>??ÄÿÔ´ºR?M#¿³a^?Ah0©°Gãm¡?¸ßË(íáÐ+?¥4?°ÊêN??yÞD3oMje?]m|6÷?qn¿ûÅØÕßVAYQkAVð3¢ªøDk?iXP\JªÉ?¤­²¼:þ¥l?¨*¥ó·^é?ckâ$fQ#T_%¡Q­¬?*ÿEß¡jêK?Zë5ÆXä
Z+<ïkz÷¡
ù§?=?Ï?s??y?Õn^`ÁÄfÅ÷¡×µöSz=°Ödj´e?êâ?§ÌÑg??'?.ÐÍb?0waâ?Þ~Ê&?±?ä¡?sQw3å=ï?~»ÿä¯?-??æ)!fà4f½ïðÀóM¨V?_gèà;D1¥U6Á&©Ð??ªóë´?È>Ç·`ÎJDI¡J?ðÖýî?OeU?Dn·æ»ø?¥P
£ÅѶ4
2J_Ä|5W?e¶÷$ëð´¸4?I´ESøí§ÐÛ
vÊà¿ïÆN=¹íjøù?<?Ö?ìTÅòg?ÎE
?dl§d´AlE'¸·Jù;Á¬"iå"º?}qlMJ';EÇvjôÐËíkêKÅÿ¶6?N??"NÔ ??Ø¥v?>òJwöËõ;?F4{Ìëä¸}º úÔ?ÂÎÌ%&´Ä?¦1!>/&ôÝû²wW?(ÑÕl?x!-?;°ÚÃ<N?xË&v=EO?Ãé¥S?x"TâË?*Ò??üP?åh÷o­Y5ò·Ãq¿í=îLa°ÚǼR%?ÒüóÕ¿FU6ëMGmgÐÆè9±?¡°ðM#a?Ó:"?Æ
?Z?À84È3#½öù¸>ûæt??§ôÍB`äïGÞù4ö0»??`¼³®E?úw<
ÁÈ,?â~ôÿ~?Ý?Be£ °Þ?ýÁ?U)~¦<??dïT?§Ávw?Ónßø/?õ??Z{4?¬?eY?;d»ÇR·Ð?ù.a¦ÚìO¦q?hJspX¢²÷!ÄöõprcBÔÎ	=âZÍ#Ä\O±R4?R=~7p??ckªõ?À?d?OÄ5?µ£ãÀM)?W£Öjz)Y~¥¯³Þñwb#?ÀMùy!Ný,ÆÔVm`R· ô­bß[ìFrW"æÏf碤ívè[¢Ò¡õDK)E¯±>à.$ý©?³dwÏ%²û¨°9»?O?f ¶WaJ«y*ÌøX?
·ÆKáÁ¨0ÇÖ$nû´L³ô`¹$>:N¥?
k?ywié¤.?q÷V?éð? 5µñ×ðQ÷??¨pjØdMçt6Çâ96»S¡(sñº?èl÷Îìö§?÷??æTèùÍ?)­]ßÆÂ??Åz£4ΦËrýÊ;Á¯1åfµ¤G?Iÿ[$Úº?	>îwúK)ô?ëYú«¸¯?0o¤¤&?ß×ßT[?ººvrU{?KÁ'ªj1Fa®þFOú?þ¦¿,ú»èïô7ø³}ÞF÷»×_?'¯¿j.?n?2±¬¿Y??Ú*MÍZ>¢¤]qlM?\µ¿2Hp)sþ¢?TªÌ}?îÄ]ªm?"ÛÑw.êνT??þæî\?]V?GS¸ë.Þ	4ù(F??|?únêü?à´õCÃo¼!¼ÍkhøMg5¯eqÓw®i_Ok:7OñÛÐI&I
¡?{?ºYMBéèH?TÞ6v?Öä 0\£·ÿÔTÕä­ ?kzh??±^ìm±5¾?D?^¢»¶?È&OS]£càÄÕ%j´3çõ'ß?¶?u?ª3Ì~îÓ«D·Q²?wG)©? E??ø¾.;6¿É6?;ïجMy?)øêÒòÅ\æ<­­UØ9{¯0õ#6&TD3ÚÅ??Í~ÿ?&k
êãÐMy¯hY¹8ú´Ü×£*MªH-vÎÆÑ
Áõä
ë¼?w/âÃË-²Ãø?9?½£y9ÅLJ¨º."X?ÉÒtN??Uô?Ê{îuQÄ?Þ®?L7?TZ
ãhä»ßÖh?½ÿ2?TZ?D#ú}?ûv?Ïùüµó¼Cxô´cî?Íò¼¹¬Ú±ç?þ­i.?G?7å?ÕÇ?ûâØ?ÜmÏ;??f)u¦ÑRB?R¤x¸àw×5s䧹עl?	Mü=»A`ü2^?÷[X|?ý½ë8`4öÙ¬aª§õ¯4.*'IGÍ?ÿIZ8zß9l?qa,?Oã\?7ÝÚeâRXALZÅs?vMT?~7???)üúºôÂf;R6n}²MdU??(ü? Ø?¦ÝeÿÈÌÞißV}ï?¸Tce@??oe?9"`ã]ñÑF?÷*þ?nÞ»
×j×õL¸·áZ!à(?_U×-#¸öF?ò ;¸V÷?kÿ1\?P-p½Àõ×\?®?4f×?Ì?keÈu¸.???k(?­©½ºµd®¡O4Û¸N¥î×? à?-p½Àõ×\?®[??k:?]Ó?p?Ä®)®+öÎÑ?®Ûñ?tì?Ý®1ì?,p½Àõ×\?®Å®g?d?p¨oõ@À5vãvüj??k[àºíc×õá:þFÀ5]àz?뮸~L0ÄNà?Ï?¸±ë"ø?)P[Sø8v][2Ù¤_JÁ&}O1ô\?é»p]Ū×´.к@ë­ÓÀ??­Rß?VDà?ck2ïâ¨H?3«.Î?JÝ?	SnÃÂ?¸^àz?ëÀu-(?Àµ?	×òFà¢þ®±)?âWbY°Ût§ºÀ?T÷\PD?¹j¸^àz?ë®ï×K?²ëY§¹æ:»î×P[?Elºëã̤Àu*u7¸fv­Ü×\/p½Àõ#ص'ÓMw³?ÁD8$·ØuüA??ck¢ï°ë\±-³ÓDÜ©T?3£Îâv¶êpèz>§wàÚê?G?ù;kÎ?Ï>ÿðø|:?í8ß^¦?£d!LÀZqÌQشΦ.è4£<­*ü: ¾¬v´¢??|N¥â[oPª~3YÈÕ??ºÓÃ???,©8¾Q*?o?%ú?;u¯cЬæÊd?Þì÷?ÖØ?æË6u*	B7?yë</¦ãSól?®ä?)â¨?¼ L Ó?0L?ìf³?ðÖ´Ï?ßAª?f
3J¦?¹Ø?ãÌG£múöå!¥i,%æè4æ?H%ròÕõ¡	ëÝúôÜÄiyx=³äí¥??Ú?%¢um'.÷µð?¤ÒØ\±Y\òNδ?.ó´¡¼u9mFÊ9gYòiÿRòjã³tîJÞoÈ%Þ	I?V¸ÏsôK´¼k{j?íÞÁJvÿ
?U)>ïÉO~?óÊ?.?ÊÄ!Jþñ¤53riw-¹? ?·ù
ô\¿·@ªâ¬Ï?þeë·?Å×ÙÅ]$@:oÆÝÛö½fé¾k"Ê$']îߨ?ù??(¨æóèõ?~³è}ı?×-ä?2»¯M?YCJ[?ÏÿË|ÉoÛôùС???Ë"|Ë?:?g"??½Ifz%ü"jtÝ+	R·äM
Ã\[Ó?Â?g+ð¤R?OaXêν\R.~Óâ7-~Ó?í7ýìþO?V¤¹ú?4pë"ðDYQ>åé;)?âÃÎÂÝîþ?r÷íù0æî±??Óº¿Á'Ú?´¢PsÔÕËR?6íÓ?SVáÁ#î.QB?!kÝÇÖtý h_Sú¯Rõ?ú¼/$·:Hä?è¹PÝ?gRϺß±?Tbò?Ku?áîwA?;­Ô?úÖJmåç­ÔJQ®?=÷pÛúHTb?XA?ýå=vãÍîõÐk¯M«k¡´?²?Ú;¹< ¤Ü? ¢?à?öÆ?XÖ^:h/2)|õz
R*k.">^h¯JÅ%gko.3??h¯ózúðxíÍ#?æÀ±mÖ»??þ?Ýoö½·x_t??5$?qdÆ?ÐUÌ???ÏMÆfú-W?àÑÍÔ?µÑ¯>ê?ckúhãÖ`õ¥fÔ?6??ökõâ2"?ÔK]{?È]Õ?ºU¤tN?Æ?§¡ÍóüìáÆ?scl?ïac?N=?F_??zZà ?ߣ¶
Þ?@ûÄiDò¢bZL¿Âzã;
R©m5Úßû×A?jC??w£ML?Y?z?à{'@'5T?Àr¥èäéi<???UÉ p?à)@¤ãüÝG]qlMá?c®S?hCå3@äR3jºEÜU?È?ÂêÒ¹ ?ø9âíU¾ æªr°²s%àæMÐÔU¾¥8¶¦ë+??­á*`?¸?L\?\*ÚuQá]	å?ìË\w%Üü4yÈ¥ºf=Ä?HÝËs mØÉ7K§õ¬Å?X\?ßëB¸	C`ób	U9ªwÍ?p?¡¢fø¨+?­É~Èú#£¢0?TjFMW]?,î:CH??#¤tnaCø1Âéyÿù?S?@§?Ít!J¦?ÑR?h[?þ?! 3åÀWÍ{gyël?$!ëJÅZ©(f%¿??åVúmMÝCù?u¶ÍKZòP?°Øå?Æ.+©§¡½t»ì¯?ö:ÁS»\{2|ÔÇÖС½Ö)ÛÙå Å??®zîYÜ
»ì»Ð??ºS综ØåÓ.oöOëÝØ.S+Ô(?3×lN;°{t|(0ÅÉ[)Á?ÁDÓ(V?ñ¨hªê?ckâ×?»&2¢·Îl´U%XoJ¥n£o?+Þv.u?2¢xZ½04T¶|g°ÝbF?~Ï>ÔÞïxÉSܪ4±óèjÇHÅÌ?fÐVÌjǽí'#Úò^Ë Qp?i:¼;ãNè»èØ?Û®Vc{Ë}µ?gEìª?'S«Ru$÷Mű5]7Â?]»?v?7Ü7?îë?ÂàF/å&÷¥ÃT@?Äê?ñ¾B°ìoÂ}©ª9ËÛ0ëCo?ÒÖP?ÞøõK¤jÃGí*;ø?¥éä þvùºªØ¨{°3ísôi?#~+û?ö>b¨¨tªªÈ)vþ˹»É?¦K»Ñ;¢yP¬Û?;?QBCÀU¶èùÀI«Ûa^66?{x?Â4L-6c³>ïù?üÌ?ÿ¹&üïþø4Æí?6££I\WÀ?¾±?Å^M¢êÚÑ$¡ë0=?T?ckr×?&q¯d¤*¹Q??y4©w	×ÃѤþ;uç^.G??£IX??øѤ?9?WÛèÀ?'¿:ú?7gïVr#rÂ.×qÂ\>gÒ®Ï?}=?Ò¦?ÁÓQe?&·ËY?å,ÍL??^ß:K?£4?â«à[µõ?½¼?ÎÛË{ÇUaª?!(?mÍÎz Rð[¢1?Q"È?ßçu×0?b5Úãø9?Ó<¹íSÄàXºã?ì
ßLÏ3øfõæ8
03R?Ï ¼»F?½W
¾zó^5ËEÈ?Ï?JL×Ⱥ{Õ¬q¦O½¸·|óÆE=oêN­ClGYtýlNY5Àç©ÛxÄtâsï1~g|?Íâs?KWçðÉy?hØþé­?ÿ?ä/%ûC{)«û9XóÜ?jØ?{?è?êï?6#©?(c"M?ËD?¦sýLc?à¿W?Ç ÷?Fͬ÷)ó)Ó8z9â;FB1ÈË¢?bfñ~4ÊkÃzU?\@s4?ïC¢þïô<YlI«?¼-hÖÕ*¯k"©Í4?PÚµ?6t?? QØ|BðUqc+²qDé²Ñv=?J¥?ìHâ0?ݤ´?¦Öæ½,§mp?Ë+ÐÂVZåC´ã!µ'{B>¾yÛ?ÖO??Rë AJ?2#Ðþ¯/lJ+Ô?>CsN¯'hx-à$Xô®¥;m¤?P4ÌïÿÞT7¿k????/H¸/Øgßêñ4ésöZ?4²Úµ-ç¼/?­I]ÝH?årØ;DEm5ï>òC©î˨?oä?ât+ê?iíóGJÚqø;?òÞ??ð?ÅÄܽÌ?Ê}?ýþ%ò?³If8Íp4J½KÒr¬&gBÉ)?ï ¨ÑT/?HÇ_@`I Aæ4êjWi'2+hÝ:[¸nÑTÎ w±)­Q=![??ý®i??ÄÅ$?%B?êë
?Ã6c?lqðÀ£Û?f³Þù7Mk¡?-ÚjÞ©i@SD????@hù
?áèä0?6?ömJS)¥Ë*PW¥u?¦b?nK6ø'¿óǵÍ|ì±²½Ks?Á ??fK*¯$)??»ÈO?v¯£$߯æ²`??_Sá;Ù²Ö?ù&ô
à@ 
LkUd?ÄVÿXßú/ú72]8?Ú¨rã4rÃK¥L?Þi?¦ 5çö??ºÁÁ??µWYɽã>tA4:
d¥RÀÁj?zåI×i	4¾µÊ~Èj#?¥º??بÔÏì??³òz? ­J ?ÎJ÷Ón¯jBät+ÛAh?ý?ɦ$?j0	i?:????ÐQö(?ÉkrÈ,1Ì:?1ååü\?è&PxÚ:¦Þ? ³$ÎH?ÔùïM?Ó<ûÍ!-AT'ÿWºÂ²þÍ

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux