On Fri, Apr 14, 2023 at 12:46:25PM +0200, Jan Kara wrote: > On Fri 14-04-23 11:02:12, Luca Vizzarro wrote: > > The interface for fcntl expects the argument passed for the command > > F_DIRNOTIFY to be of type int. The current code wrongly treats it as > > a long. In order to avoid access to undefined bits, we should explicitly > > cast the argument to int. > > > > Cc: Kevin Brodsky <Kevin.Brodsky@xxxxxxx> > > Cc: Szabolcs Nagy <Szabolcs.Nagy@xxxxxxx> > > Cc: "Theodore Ts'o" <tytso@xxxxxxx> > > Cc: David Laight <David.Laight@xxxxxxxxxx> > > Cc: Mark Rutland <Mark.Rutland@xxxxxxx> > > Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> > > Cc: Christian Brauner <brauner@xxxxxxxxxx> > > Cc: Jeff Layton <jlayton@xxxxxxxxxx> > > Cc: Chuck Lever <chuck.lever@xxxxxxxxxx> > > Cc: linux-fsdevel@xxxxxxxxxxxxxxx > > Cc: Jan Kara <jack@xxxxxxx> > > Cc: Amir Goldstein <amir73il@xxxxxxxxx> > > Signed-off-by: Luca Vizzarro <Luca.Vizzarro@xxxxxxx> > > Looks good to me. Do you plan to merge this series together (perhaps > Christian could?) or should I pick up the dnotify patch? In case someone > else will merge the patch feel free to add: > > Acked-by: Jan Kara <jack@xxxxxxx> Yeah, I'm happy to carry it once it's reviewed if noone objects.