On 13.04.23 13:29, Yosry Ahmed wrote:
On Thu, Apr 13, 2023 at 4:21 AM David Hildenbrand <david@xxxxxxxxxx> wrote:
On 13.04.23 12:40, Yosry Ahmed wrote:
During reclaim, we keep track of pages reclaimed from other means than
LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab,
which we stash a pointer to in current task_struct.
However, we keep track of more than just reclaimed slab pages through
this. We also use it for clean file pages dropped through pruned inodes,
and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add
Would "reclaimed_non_lru" be more expressive? Then,
mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages()
Apart from that LGTM.
Thanks!
I suck at naming things. If you think "reclaimed_non_lru" is better,
then we can do that. FWIW mm_account_reclaimed_pages() was taken from
a suggestion from Dave Chinner. My initial version had a terrible
name: report_freed_pages(), so I am happy with whatever you see fit.
Should I re-spin for this or can we change it in place?
Respin would be good, but maybe wait a bit more on other comments. I'm
bad at naming things as well :)
--
Thanks,
David / dhildenb
