Jan Kara <jack@xxxxxxx> writes: > Hi Ritesh! > > On Tue 11-04-23 10:51:48, Ritesh Harjani (IBM) wrote: >> Please find the series which moves ext2 direct-io to use modern iomap interface. >> >> Here are some more details - >> 1. Patch-1: Fixes a kernel bug_on problem with ext2 dax code (found during code >> review and testing). >> 2. Patch-2: Adds a __generic_file_fsync_nolock implementation as we had >> discussed. >> 3. Patch-3 & Patch-4: Moves ext4 nojournal and ext2 to use _nolock method. >> 4. Patch-5: This is the main patch which moves ext2 direct-io to use iomap. >> (more details can be found in the patch) >> 5. Patch-6: Kills IOMAP_DIO_NOSYNC flag as it is not in use by any filesystem. >> 6. Patch-7: adds IOCB_STRINGS macro for use in trace events for better trace >> output of iocb flags. >> 7. Patch-8: Add ext2 trace point for DIO. >> >> Testing: >> ========= >> This passes ext2 "auto" group testing for fstests. There were no new failures >> with this patches. > > I went through the patches and I have no further comments besides what has > been already said. So feel free to update patches based on other feedback, > I'll do the last round of review and can queue the patches to my tree. > Sure, thanks Jan for going over the patches. I will send the next rev soon addressing review comments along with some other minor changes. -ritesh
