On Tue, Apr 11, 2023 at 10:51:50AM +0530, Ritesh Harjani (IBM) wrote: > +/** > + * __generic_file_fsync_nolock - generic fsync implementation for simple > + * filesystems with no inode lock No reallz need for the __ prefix in the name. > +extern int __generic_file_fsync_nolock(struct file *, loff_t, loff_t, int); No need for the extern. And at least I personally prefer to spell out the parameter names to make the prototype much more readable.
