Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > Thanks for splitting off a smaller series! > My day is out of hours so just a trivial comment, in case kbuild bot > hasn't pinged you - this appears to break the build on the relatively > recently added page_frag_cache in google's vNIC (gve). Yep. I've just been fixing that up. I'll also break off the samples patch and that can go by itself. Is there a problem with the 32-bit userspace build environment that patchwork is using? The sample programs that patch adds are all userspace helpers. It seems that <features.h> is referencing a file that doesn't exist: In file included from /usr/include/features.h:514, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdio.h:27, from ../samples/net/alg-hash.c:9: /usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such file or directory 7 | # include <gnu/stubs-32.h> | ^~~~~~~~~~~~~~~~ compilation terminated. Excerpt from: https://patchwork.hopto.org/static/nipa/737278/13202278/build_32bit/ https://patchwork.kernel.org/project/netdevbpf/patch/20230405165339.3468808-2-dhowells@xxxxxxxxxx/ David