On Mon, Apr 3, 2023 at 8:03 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 4/3/23 11:00?AM, Amir Goldstein wrote: > > On Wed, Mar 22, 2023 at 9:08?AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > >> > >> On Wed, Mar 22, 2023 at 8:51?AM Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx> wrote: > >>> > >>> The fsnotify ACCESS and MODIFY event are missing when manipulating a file > >>> with splice(2). > >>> > > > > Jens, Jan, > > > > FYI, I've audited aio routines and found that > > fsnotify_access()/modify() are also missing in aio_complete_rw() > > and in io_complete_rw_iopoll() (io_req_io_end() should be called?). > > > > I am not using/testing aio/io_uring usually, so I wasn't planning on sending > > a patch any time soon. I'll get to it someday. > > Just wanted to bring this to public attention in case someone is > > interested in testing/fixing. > > aio has never done fsnotify, but I think that's probably an oversight. I know. and I am not keen either on fixing something that nobody complained about. > io_uring does do it for non-polled IO, I don't think there's much point > in adding it to IOPOLL however. Not really seeing any use cases where > that would make sense. > Users subscribe to fsnotify because they want to be notified of changes/ access to a file. Why do you think that polled IO should be exempt? Again, not keep on fixing something nobody complained about. I'm asking out of curiosity. Thanks, Amir.
