Re: [PATCH 06/12] writeback: separate the flushing state/task from the bdi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 25 2009, Jan Kara wrote:
> On Mon 25-05-09 09:34:41, Jens Axboe wrote:
> > Add a struct bdi_writeback for tracking and handling dirty IO. This
> > is in preparation for adding > 1 flusher task per bdi.
> > 
> > Signed-off-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
> ...
> >  static int bdi_start_fn(void *ptr)
> >  {
> > -	struct backing_dev_info *bdi = ptr;
> > +	struct bdi_writeback *wb = ptr;
> > +	struct backing_dev_info *bdi = wb->bdi;
> >  	struct task_struct *tsk = current;
> > -
> > -	/*
> > -	 * Add us to the active bdi_list
> > -	 */
> > -	mutex_lock(&bdi_lock);
> > -	list_add(&bdi->bdi_list, &bdi_list);
> > -	mutex_unlock(&bdi_lock);
>   I'm probably missing something but I cannot find where the bdi is added
> to the bdi_list after this patch...

For some reason, that part is now in the following patch. The two hunks
should just be deleted, good catch!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux