On 3/28/23 2:38 PM, Al Viro wrote: > On Tue, Mar 28, 2023 at 11:43:34AM -0700, Linus Torvalds wrote: > >> And if you go blind from looking at that patch, I will not accept >> responsibility. > > ... and all that, er, cleverness - for the sake of a single piece of shit > driver for piece of shit hardware *and* equally beautiful ABI. > > Is it really worth bothering with? And if anyone has doubts about the > inturdprize kwality of the ABI in question, I suggest taking a look at > hfi1_user_sdma_process_request() - that's where the horrors are. It is horrible code, I only go as far as that very function before deciding that I wasn't going to be touching it as part of this. I do like the cleverness of the overlay, the only practical downside I see are things that _assign_ to eg iter->iovec after setting it up. That would lead to some, ehm, interesting side effects. -- Jens Axboe
