On Thu, 23 Mar 2023 14:48:25 +0800 Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote: > > > 在 2023/3/23 7:12, Andrew Morton 写道: > > On Wed, 22 Mar 2023 07:25:58 +0000 Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote: > > > >> In an dedupe corporation iter loop, the length of iomap_iter decreases > >> because it implies the remaining length after each iteration. The > >> compare function should use the min length of the current iters, not the > >> total length. > > > > Please describe the user-visible runtime effects of this flaw, thanks. > > This patch fixes fail of generic/561, with test config: > > export TEST_DEV=/dev/pmem0 > export TEST_DIR=/mnt/test > export SCRATCH_DEV=/dev/pmem1 > export SCRATCH_MNT=/mnt/scratch > export MKFS_OPTIONS="-m reflink=1,rmapbt=1" > export MOUNT_OPTIONS="-o dax" > export XFS_MOUNT_OPTIONS="-o dax" Again, how does the bug impact real-world kernel users? Thanks.