On Wed 15-03-23 19:08:57, Fabio M. De Francesco wrote:
> On mercoledì 1 marzo 2023 15:14:16 CET Al Viro wrote:
> > On Wed, Mar 01, 2023 at 02:00:18PM +0100, Jan Kara wrote:
> > > On Wed 01-03-23 12:20:56, Fabio M. De Francesco wrote:
> > > > On venerdì 24 febbraio 2023 04:26:57 CET Al Viro wrote:
> > > > > Fabio's "switch to kmap_local_page()" patchset (originally after the
> > > > >
> > > > > ext2 counterpart, with a lot of cleaning up done to it; as the matter
> of
> > > > > fact, ext2 side is in need of similar cleanups - calling conventions
> > > > > there
> > > > > are bloody awful).
> > > >
>
> [snip]
>
> >
> > I think I've pushed a demo patchset to vfs.git at some point back in
> > January... Yep - see #work.ext2 in there; completely untested, though.
>
> The following commits from the VFS tree, #work.ext2 look good to me.
>
> f5b399373756 ("ext2: use offset_in_page() instead of open-coding it as
> subtraction")
> c7248e221fb5 ("ext2_get_page(): saner type")
> 470e54a09898 ("ext2_put_page(): accept any pointer within the page")
> 15abcc147cf7 ("ext2_{set_link,delete_entry}(): don't bother with page_addr")
> 16a5ee2027b7 ("ext2_find_entry()/ext2_dotdot(): callers don't need page_addr
> anymore")
>
> Reviewed-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
Thanks!
> I could only read the code but I could not test it in the same QEMU/KVM x86_32
> VM where I test all my HIGHMEM related work.
>
> Btrfs as well as all the other filesystems I converted to kmap_local_page()
> don't make the processes in the VM to crash, whereas the xfstests on ext2
> trigger the OOM killer at random tests (only sometimes they exit gracefully).
>
> FYI, I tried to run the tests with 6GB of RAM, booting a kernel with
> HIGHMEM64GB enabled. I cannot add my "Tested-by" tag.
Hum, interesting. Reading your previous emails this didn't seem to happen
before applying this series, did it?
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
