On 3/15/23 9:12 AM, Jens Axboe wrote: > On 3/15/23 9:02 AM, Christian Brauner wrote: >> On Wed, Mar 15, 2023 at 08:16:19AM -0600, Jens Axboe wrote: >>> On 3/15/23 2:23 AM, Christian Brauner wrote: >>>> On Tue, Mar 14, 2023 at 09:42:02AM -0600, Jens Axboe wrote: >>>>> In preparation for enabling FMODE_NOWAIT for pipes, ensure that the read >>>>> and write path handle it correctly. This includes the pipe locking, >>>>> page allocation for writes, and confirming pipe buffers. >>>>> >>>>> Acked-by: Dave Chinner <dchinner@xxxxxxxxxx> >>>>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> >>>>> --- >>>> >>>> Looks good, >>>> Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx> >>> >>> Thanks for the review, I'll add that. Are you OK with me carrying >>> these patches, or do you want to stage them for 6.4? >> >> I'n not fuzzed. Since it's fs only I would lean towards carrying it. I >> can pick it up now and see if Al has any strong opinions on this one. > > Either way is fine with me - let me know if you pick it up, and > I can drop it from my tree. Oh and if you do, I should probably send out a v3. Was missing a kerneldoc in patch 1, corrected that in my tree but it's not in v2. Outside of that one-liner doc change, same patches in my tree. -- Jens Axboe