Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 14 Mar 2023 10:32:25 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Steve French <smfrench@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx
In-reply-to: <20230308165251.2078898-8-dhowells@redhat.com>

On Wed, Mar 08, 2023 at 04:52:44PM +0000, David Howells wrote:
> Make generic_file_splice_read() use filemap_splice_read() and
> direct_splice_read() rather than using an ITER_PIPE and call_read_iter().
> 
> Make cifs use generic_file_splice_read() rather than doing it for itself.

Please split the cifs patch out into a separate one.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v17 00/14] splice, block: Use page pinning and kill ITER_PIPE
  - From: David Howells
- [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE
  - From: David Howells

Prev by Date: Re: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it
Next by Date: Re: [PATCH v17 09/14] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing
Previous by thread: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE
Next by thread: Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]