On Fri, Mar 10, 2023 at 09:25:36PM +0000, Al Viro wrote: > fget()/fget_raw() should be used when we are going to keep > struct file reference; for temporary references fdget()/fdget_raw() > ought to be used. That kind of stuff keeps cropping up on a regular Fwiw, might be worth to mention/document that explicitly anywhere. I didn't see anything but might've missed it. > basis, and it needs periodic pruning. > > The current pile is in vfs.git #work.fd; individual patches > in followups. Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>