On Thu, Mar 09, 2023 at 06:32:41PM +0800, Qu Wenruo wrote: >> This looks mostly ok to me. I suspect in the longer run all metadata >> I/O might be able to use this helper as well. > > IMHO metadata would also go into the btrfs_check_read_bio(). Why? The reason data checksum verification is down there is so that it can deal with split bios. Metadata never gets split, so it is more logical to keep the metadata verification in the extent_buffer code.