On 3/7/23 00:49, Jiapeng Chong wrote: > The variable ret belongs to redundant assignment and can be deleted. > > fs/splice.c:940:2: warning: Value stored to 'ret' is never read. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4406 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > --- > fs/splice.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/splice.c b/fs/splice.c > index 2e76dbb81a8f..2c3dec2b6dfa 100644 > --- a/fs/splice.c > +++ b/fs/splice.c > @@ -937,7 +937,6 @@ ssize_t splice_direct_to_actor(struct file *in, struct splice_desc *sd, > /* > * Do the splice. > */ > - ret = 0; > bytes = 0; > len = sd->total_len; > flags = sd->flags; Looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck
