On 3/7/23 23:13, Jiapeng Chong wrote: > Variable 'cmd' set but not used. > > fs/locks.c:2428:3: warning: Value stored to 'cmd' is never read. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4439 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > --- > fs/locks.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/locks.c b/fs/locks.c > index 66b4eef09db5..d82c4cacdfb9 100644 > --- a/fs/locks.c > +++ b/fs/locks.c > @@ -2425,7 +2425,6 @@ int fcntl_getlk64(struct file *filp, unsigned int cmd, struct flock64 *flock) > if (flock->l_pid != 0) > goto out; > > - cmd = F_GETLK64; > fl->fl_flags |= FL_OFDLCK; > fl->fl_owner = filp; > } Indeed cmd is not used after this assignment in above function. Looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck
