On 3/7/23 5:19 PM, Dave Chinner wrote: > On Tue, Mar 07, 2023 at 08:45:31AM -0700, Jens Axboe wrote: >> Hi, >> >> File types that implement read_iter/write_iter should check for >> IOCB_NOWAIT > > Since when? If so, what's the point of setting FMODE_NOWAIT when the > struct file is opened to indicate the file has comprehensive > IOCB_NOWAIT support in the underlying IO path? Guess I missed that FMODE_NOWAIT is supposed to be added for that, my naive assumption was that the iter based one should check. Which is a bad sad, but at least there's a flag for it. But the good news is that I can drop the io_uring patch, just need to revise the pipe patch. I'll send a v2. -- Jens Axboe
