One tiny little thing that crossed my mind as I was looking at this... > - REFLINK_ATTR_NONE is 0 and REFLINK_ATTR_ALL is ~0. That, I think, could lead to unexpected results if different flags (perhaps controlling different aspects of behavior altogether) are added in the future. Might it make more sense for REFLINK_ATTR_ALL to be something like 0xffff, with the current implementation insisting that all other bits are zero? That would leave room for expansion of the set of things covered by the "preserve all" semantics while, simultaneously, allowing the addition of different types of flags entirely. jon -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
