On Thu, 2023-03-02 at 18:14 +0000, Al Viro wrote: > On Wed, Mar 01, 2023 at 06:20:18PM +0100, Jakob Koschel wrote: > > 'victim' and 'fl' are ensured to be equal at this point. For consistency > > both should use the same variable. > > > > Additionally, Linus proposed to avoid any use of the list iterator > > variable after the loop, in the attempt to move the list iterator > > variable declaration into the marcro to avoid any potential misuse after > > the loop [1]. > > > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@xxxxxxxxxxxxxx/ [1] > > Signed-off-by: Jakob Koschel <jkl820.git@xxxxxxxxx> > > Looks sane. Jeff, which tree do you want that to go through? Looks good to me too. I'm fine if you want to pick up that one, but otherwise I can take it. You can also add: Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> Thanks!
