On mercoledì 1 marzo 2023 14:00:18 CET Jan Kara wrote: > On Wed 01-03-23 12:20:56, Fabio M. De Francesco wrote: > > On venerdì 24 febbraio 2023 04:26:57 CET Al Viro wrote: > > > Fabio's "switch to kmap_local_page()" patchset (originally after the > > > > > > ext2 counterpart, with a lot of cleaning up done to it; as the matter of > > > fact, ext2 side is in need of similar cleanups - calling conventions there > > > are bloody awful). > > > > If nobody else is already working on these cleanups in ext2 following your > > suggestion, I'd be happy to work on this by the end of this week. I only > > need > > a confirmation because I'd hate to duplicate someone else work. > > > > > Plus the equivalents of minix stuff... > > > > I don't know this other filesystem but I could take a look and see whether > > it > > resembles somehow sysv and ext2 (if so, this work would be pretty simple > > too, > > thanks to your kind suggestions when I worked on sysv and ufs). > > > > I'm adding Jan to the Cc list to hear whether he is aware of anybody else > > working on this changes for ext2. I'm waiting for a reply from you (@Al) or > > Jan to avoid duplication (as said above). > > I'm not sure what exactly Al doesn't like about how ext2 handles pages and > mapping but if you have some cleanups in mind, sure go ahead. Hi Jan, I might explain here and now what Al is referring to I'd prefer to show the code :-) In brief I had made the conversions of fs/ufs and fs/sysv from kmap() to kmap_local_page() by porting what had been done for ext2. At that point Al suggested a much cleaner and elegant approach. Therefore, I threw away the port from ext2 and sent a series of 4 patches according to a long list of suggestions that Al kindly provided to me. Now he is asking for somebody doing the same changes in ext2 too. Thanks for the immediate reply. Fabio > I don't have > any plans on working on that code in the near term. > > Honza > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR
