On Tue, Feb 28, 2023 at 9:18 AM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > On Tue, Feb 28, 2023 at 3:56 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > > > Hi Yosry, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on akpm-mm/mm-everything] > > [also build test ERROR on linus/master next-20230228] > > [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com > > patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim > > config: i386-randconfig-a002-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281933.vU1PHuZr-lkp@xxxxxxxxx/config) > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > > git checkout f6d2b849f186a927925a29e289d60895048550f5 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Link: https://lore.kernel.org/oe-kbuild-all/202302281933.vU1PHuZr-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim' > > static bool cgroup_reclaim(struct scan_control *sc) > > ^ > > mm/vmscan.c:191:13: note: previous definition is here > > static bool cgroup_reclaim(struct scan_control *sc) > > ^ > > >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim' > > static bool global_reclaim(struct scan_control *sc) > > ^ > > mm/vmscan.c:196:13: note: previous definition is here > > static bool global_reclaim(struct scan_control *sc) > > ^ > > 2 errors generated. > > Ugh yeah I didn't realize I am moving the definitions from within an > #ifdef CONFIG_MEMCG. I will just leave the definitions as-is and add a > forward declaration before the definition of > add_non_vmscan_reclaimed(), should also reduce the churn in the diff. > Will wait for a bit before re-spinning to gather some feedback on the > current version first. I can also just move all the reclaim state functions (set_task_reclaim_state(), report_freed_pages(), add_non_vmscan_reclaimed()) below that #ifdef CONFIG_MEMCG. Might also name them more consistently. > > > > > > > vim +/cgroup_reclaim +549 mm/vmscan.c > > > > 86750830468506 Yang Shi 2021-05-04 548 > > b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc) > > 89b5fae5368f6a Johannes Weiner 2012-01-12 550 { > > b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false; > > 89b5fae5368f6a Johannes Weiner 2012-01-12 552 } > > 97c9341f727105 Tejun Heo 2015-05-22 553 > > a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc) > > a579086c99ed70 Yu Zhao 2022-12-21 555 { > > a579086c99ed70 Yu Zhao 2022-12-21 556 return true; > > a579086c99ed70 Yu Zhao 2022-12-21 557 } > > a579086c99ed70 Yu Zhao 2022-12-21 558 > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests
