2023-02-27 11:20 GMT+09:00, Andy.Wu@xxxxxxxx <Andy.Wu@xxxxxxxx>: > Hi Namjae: Hi Andy, > >> > + if (hint_clu == sbi->num_clusters) { >> > hint_clu = EXFAT_FIRST_CLUSTER; >> > p_chain->flags = ALLOC_FAT_CHAIN; >> > } > This is normal case, so let exfat rewind to the first cluster. > >> > + /* check cluster validation */ >> > + if (!is_valid_cluster(sbi, hint_clu)) { >> > + exfat_err(sb, "hint_cluster is invalid (%u)", hint_clu); >> > + ret = -EIO; >> There is no problem with allocation when invalid hint clu. >> It is right to handle it as before instead returning -EIO. > We think all other case are real error case, so, error print and return > EIO. Why ? > May I confirm is there any normal case in here? Could you please explain more ? I can't understand what you are saying. > > Best Regards > Andy Wu > >