On Sun, Feb 26, 2023 at 11:56:05PM +0000, Matthew Wilcox wrote: > On Mon, Feb 27, 2023 at 10:48:14AM +1100, Dave Chinner wrote: > > > +static void iomap_iop_set_range_dirty(struct folio *folio, > > > + struct iomap_page *iop, size_t off, size_t len) > > > +{ > > > + struct inode *inode = folio->mapping->host; > > > + unsigned int nr_blocks = i_blocks_per_folio(inode, folio); > > > + unsigned first = (off >> inode->i_blkbits); > > > + unsigned last = ((off + len - 1) >> inode->i_blkbits); > > > > first_bit, last_bit if we are leaving this code unchanged. > > first_blk, last_blk, surely? Probably. And that's entirely my point - the variable names need to describe what they contain... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx