> On Feb 24, 2023, at 7:01 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Fri, Feb 24, 2023 at 05:09:26PM -0800, Viacheslav Dubeyko wrote:
>> +int ssdfs_read_folio(struct file *file, struct folio *folio)
>> +{
>> + struct page *page = &folio->page;
>
> I'm not really excited about merging a new filesystem that's still using
> all the pre-folio APIs. At least you're not using buffer_heads, but
> you are using some APIs which have been entirely removed in 6.3.
I am adopting the folio API step by step. :) I completely agree that SSDFS should use
the folio API. As far as I can see, the folio approach is going into the kernel gradually.
And I am making changes in SSDFS code with every kernel version. So, the goal of review
is to point me out what should be reworked in SSDFS code. And I am happy to rework
the SSDFS code.
Thanks,
Slava.
