Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 10:19:47AM -0600: > ...of course, relooking at the functions in mm/filemap.c it seems like > I can probably just use filemap_fdatawrite > instead of having my own flush function since it basically sets up wbc > the same way.... hmm, I was basing myself off file_write_and_wait_range that also calls file_check_and_advance_wb_err before returning, but the wait actually comes from fdatawrite in there... So, right: - WB_SYNC is probably ok, but if we go that way let's use filemap_fdatawrite -- less things to think about :) - if we want any sort of error reporting file_check_and_advance_wb_err() is probably useful, at which point keeping the old function is just as good. That doesn't do any wait, just checks f_wb_err ... in a really complicated way... I don't want to have to think about. -- Dominique
