Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:21AM +0000: > Checking the p9_fid_put value allows us to pass back errors > involved if we end up clunking the fid as part of dir_release. > > This can help with more graceful response to errors in writeback > among other things. That is good! Note if there are other refs we won't see any error :/ But I think we should check p9_fid_put return value way more often, even if all we do with it is print a warning at some debug level for context. Reviewed-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx> -- Dominique
