Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 13 Feb 2023 06:46:59 -0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>
In-reply-to: <20230213134619.2198965-4-dhowells@redhat.com>

On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote:
> +	init_sync_kiocb(&iocb, in);
> +	iocb.ki_pos = *ppos;
> +	iocb.ki_flags &= IOCB_NOWAIT;

This clears everything but IOCB_NOWAIT.  But even IOCB_NOWAIT should
not be cleared here as far as I can tell.

References:
- [PATCH 0/4] iov_iter: Adjust styling/location of new splice functions
  - From: David Howells
- [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()
  - From: David Howells

Prev by Date: Re: [PATCH 2/4] splice: Provide pipe_head_buf() helper
Next by Date: Re: [PATCH 4/4] splice: Move filemap_read_splice() to mm/filemap.c
Previous by thread: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()
Next by thread: Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]