Re: copy on write for splice() from file to pipe?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: copy on write for splice() from file to pipe?
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 11 Feb 2023 10:57:54 -0800
Cc: Ming Lei <ming.lei@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Stefan Metzmacher <metze@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux API Mailing List <linux-api@xxxxxxxxxxxxxxx>, io-uring <io-uring@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Samba Technical <samba-technical@xxxxxxxxxxxxxxx>
In-reply-to: <787c3b62-f5d8-694d-cd2f-24b40848e39f@kernel.dk>

On Sat, Feb 11, 2023 at 7:33 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> OK, but then the ignore_sig change should not be needed at all, just
> changing that first bit to fatal_signal_pending() would do the trick?

Right. That was my point. The 'ignore_sig' flag just doesn't make
sense. It was a hack for a case that shouldn't exist.

              Linus

Follow-Ups:
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe

References:
- Re: copy on write for splice() from file to pipe?
  - From: Linus Torvalds
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe
- Re: copy on write for splice() from file to pipe?
  - From: Linus Torvalds
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe
- Re: copy on write for splice() from file to pipe?
  - From: Andy Lutomirski
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe
- Re: copy on write for splice() from file to pipe?
  - From: Linus Torvalds
- Re: copy on write for splice() from file to pipe?
  - From: Ming Lei
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe
- Re: copy on write for splice() from file to pipe?
  - From: Ming Lei
- Re: copy on write for splice() from file to pipe?
  - From: Jens Axboe

Prev by Date: Re: [PATCH 1/4] fs/splice: enhance direct pipe & splice for moving pages in kernel
Next by Date: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN
Previous by thread: Re: copy on write for splice() from file to pipe?
Next by thread: Re: copy on write for splice() from file to pipe?
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]