Re: [PATCH 02/23] block: add a bvec_set_folio helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 02/23] block: add a bvec_set_folio helper
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Tue, 31 Jan 2023 06:55:23 +0000
Accept-language: en-US
Cc: Ilya Dryomov <idryomov@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Marc Dionne <marc.dionne@xxxxxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna@xxxxxxxxxx>, Mike Marshall <hubcap@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "ceph-devel@xxxxxxxxxxxxxxx" <ceph-devel@xxxxxxxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-afs@xxxxxxxxxxxxxxxxxxx" <linux-afs@xxxxxxxxxxxxxxxxxxx>, "linux-cifs@xxxxxxxxxxxxxxx" <linux-cifs@xxxxxxxxxxxxxxx>, "samba-technical@xxxxxxxxxxxxxxx" <samba-technical@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "devel@xxxxxxxxxxxxxxxxxx" <devel@xxxxxxxxxxxxxxxxxx>, "io-uring@xxxxxxxxxxxxxxx" <io-uring@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>
In-reply-to: <20230130092157.1759539-3-hch@lst.de>
Thread-index: AQHZNIxeh/gfUAK4JkCEUdJ/EBv35q64GOKA
Thread-topic: [PATCH 02/23] block: add a bvec_set_folio helper
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

On 1/30/23 01:21, Christoph Hellwig wrote:
> A smaller wrapper around bvec_set_page that takes a folio instead.
> There are only two potential users for this in the tree, but the number
> will grow in the future.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck

References:
- add bvec initialization helpers
  - From: Christoph Hellwig
- [PATCH 02/23] block: add a bvec_set_folio helper
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 01/23] block: factor out a bvec_set_page helper
Next by Date: Re: [PATCH 03/23] block: add a bvec_set_virt helper
Previous by thread: Re: [PATCH 02/23] block: add a bvec_set_folio helper
Next by thread: [PATCH 04/23] sd: factor out a sd_set_special_bvec helper
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]