On Wed, Jan 25, 2023 at 12:28:46PM +0100, Christian Brauner wrote:
> +static int xattr_list_one(char **buffer, ssize_t *remaining_size,
> + const char *name)
> +{
> + size_t len = strlen(name) + 1;
> + if (*buffer) {
Empty line after the variable declaraion(s), please.
> +static int posix_acl_listxattr(struct inode *inode, char **buffer,
> + ssize_t *remaining_size)
> +{
> +#ifdef CONFIG_FS_POSIX_ACL
This function should go into posix_acl.c, with a stub in the header
instead of the ifdef.
> + err = posix_acl_listxattr(d_inode(dentry), &buffer, &remaining_size);
> + if (err)
> + return err;
And I suspect the call to posix_acl_listxattr should move into the caller in
the VFS instead of the method, just like ACLs are handled in
the get/set side.
