Re: [PATCH 2/2] ->write_super lock_super pushdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 12, 2009 at 01:10:10PM +0300, Boaz Harrosh wrote:
> Please I have a question about this?
> 
> lock_super():
>   I do not see any other lock_super() in exofs, so all this might "lock" is
>   race against itself, right?

Yes.

>   Should I make sure that concurrent
>   exofs_write_super are protected some other way and remove this?

Yes.

> 
> lock_kernel();
>   What is that used for? What should I check so this can be removed?

lock kernel is the big kernel lock as in the very first lock that was
added when Linux grew SMP support.  If you filesystem does internal
locking you most likely don't need this one at all.  The only superblock
method still called with the BKL in the vfs tree is remount, but it
will most likely be gone before 2.6.31, too.  After that you can do
a quick audit if there was anything it protected against and remove it.

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux