On Tue, Jan 24, 2023 at 05:01:06PM +0000, David Howells wrote: > Add BIO_PAGE_PINNED to indicate that the pages in a bio are pinned > (FOLL_PIN) and that the pin will need removing. The subject is odd when this doesn't actually switch anything, but just adds the infrastructure to unpin pages. > +/* > + * Set the cleanup mode for a bio from an iterator and the extraction flags. > + */ > +static inline void bio_set_cleanup_mode(struct bio *bio, struct iov_iter *iter) > +{ > + if (iov_iter_extract_will_pin(iter)) > + bio_set_flag(bio, BIO_PAGE_PINNED); > +} At this point I'd be tempted to just open code these two lines instead of adding a helper, but I can live with the helper if you prefer it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>