As a pure mechanical move this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But some comments: > + struct inode *inode = page->mapping->host; > + char *kaddr; > + struct udf_inode_info *iinfo = UDF_I(inode); > + > + BUG_ON(!PageLocked(page)); > + > + kaddr = kmap_atomic(page); > + memcpy(iinfo->i_data + iinfo->i_lenEAttr, kaddr, i_size_read(inode)); > + SetPageUptodate(page); > + kunmap_atomic(kaddr); > + unlock_page(page); This really should be using memcpy_to_page. And the SetPageUptodate here in ->writepages loos a little odd as well.
