On Thu, May 07, 2009 at 10:59:04PM -0400, jim owens wrote: > - fix the > + if (S_ISDIR(inode->i_mode)) > + return -EPERM; > > to be an ISREG check unless you have an argument for > special files and symlinks being COWed. I'm unsure on this one, and would like other comments. Why? It doesn't *hurt* to allow reflink on symlinks or special files. Mostly it's a waste - symlinks may have a data extent, but special files do not. But I'm not sure there's a point to arbitrarily limit filesystems when there's nothing we're combating. Jim, if you have a real problem this prevents, I'm all ears. And if others concur that restricting it to regular files is the right way to go, I can be convinced. Joel -- "Hey mister if you're gonna walk on water, Could you drop a line my way?" Joel Becker Principal Software Developer Oracle E-mail: joel.becker@xxxxxxxxxx Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
