Re: [PATCH v3 4/4] fs/sysv: Replace kmap() with kmap_local_page()

[Matthew Wilcox <willy@xxxxxxxxxxxxx>]

On Fri, Jan 20, 2023 at 04:21:06AM +0000, Al Viro wrote:
> On Thu, Jan 19, 2023 at 04:32:32PM +0100, Fabio M. De Francesco wrote:
> 
> > -inline void dir_put_page(struct page *page)
> > +inline void dir_put_page(struct page *page, void *page_addr)
> >  {
> > -	kunmap(page);
> > +	kunmap_local(page_addr);
> 
> ... and that needed to be fixed - at some point "round down to beginning of
> page" got lost in rebasing...

You don't need to round down in kunmap().  See:

void kunmap_local_indexed(const void *vaddr)
{
        unsigned long addr = (unsigned long) vaddr & PAGE_MASK;