Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Wed, 18 Jan 2023 22:28:28 +0000
Cc: David Howells <dhowells@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Y8ZVGEvbVsf4eDNU@infradead.org>

On Mon, Jan 16, 2023 at 11:58:16PM -0800, Christoph Hellwig wrote:
> On Mon, Jan 16, 2023 at 11:08:44PM +0000, David Howells wrote:
> > Use the direction in the iterator functions rather than READ/WRITE.
> 
> I don't think we need the direction at all as nothing uses it any more.

... except for checks in copy_from_iter() et.al.

Follow-Ups:
- Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: Christoph Hellwig

References:
- [PATCH v6 00/34] iov_iter: Improve page extraction (ref, pin or just list)
  - From: David Howells
- [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: David Howells
- Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v6 02/34] iov_iter: Use IOCB/IOMAP_WRITE/op_is_write rather than iterator direction
Next by Date: Re: [PATCH v7 3/4] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs
Previous by thread: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
Next by thread: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]