Re: [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page
From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 17 Jan 2023 08:21:31 +0000
Cc: dhowells@xxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Y8ZWD82dvoulSG8k@infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Mon, Jan 16, 2023 at 11:08:59PM +0000, David Howells wrote:
> > Provide a helper in the get_user_pages code to drop a pin or a ref on a
> > page based on being given FOLL_GET or FOLL_PIN in its flags argument or do
> > nothing if neither is set.
> 
> Please don't add new page based helpers.

Yes, I know, but all of the callers still use pages, not folios.

David

References:
- Re: [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page
  - From: Christoph Hellwig
- [PATCH v6 00/34] iov_iter: Improve page extraction (ref, pin or just list)
  - From: David Howells
- [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page
  - From: David Howells

Prev by Date: Re: [PATCH v6 07/34] iov_iter: Add a function to extract a page list from an iterator
Next by Date: Re: [PATCH v6 11/34] iov_iter, block: Make bio structs pin pages rather than ref'ing if appropriate
Previous by thread: Re: [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page
Next by thread: [PATCH v6 10/34] mm, block: Make BIO_PAGE_REFFED/PINNED the same as FOLL_GET/PIN numerically
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]