On Thu, 12 Jan 2023 11:27:20 +0800 Chao Yu <chao@xxxxxxxxxx> wrote: > proc_notify_change() has updated i_uid, i_gid and i_mode into proc > dirent, we don't need to call mark_inode_dirty() for later writeback, > remove it. > > --- a/fs/proc/generic.c > +++ b/fs/proc/generic.c > @@ -127,7 +127,6 @@ static int proc_notify_change(struct user_namespace *mnt_userns, > return error; > > setattr_copy(&init_user_ns, inode, iattr); > - mark_inode_dirty(inode); > > proc_set_user(de, inode->i_uid, inode->i_gid); > de->mode = inode->i_mode; procfs call mark_inode_dirty() in three places. Does mark_inode_dirty() of a procfs file actually serve any purpose?
