Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > This allows all but three of the users of iov_iter_rw() to be got rid of: a > > consistency check and a warning statement in cifs > > Let's just drop these two. > > > and one user in the block > > layer that has neither available. > > And use the information in the request for this one (see patch below), > and then move this patch first in the series, add an explicit direction > parameter in the gup_flags to the get/pin helper and drop iov_iter_rw > and the whole confusing source/dest information in the iov_iter entirely, > which is a really nice big tree wide cleanup that remove redundant > information. Fine by me, but Al might object as I think he wanted the internal checks. Al? David