On Mon, Jan 09, 2023 at 06:25:54PM -0800, Luis Chamberlain wrote: > During commit e462ec50cb5 ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") Christoph had suggested we should eventually > remove these old flags which were exposed to userspace but could not > be used as they were internal-only. > > Nuke them. Umm... They are still exposed to userland after your series, though. IOW, we can't change the bit assignment of e.g. SB_ACTIVE - the apparmor part will break, etc. If anything, it would be more honest to lift the "we ignore those bits" logics to path_mount()...