On Sun, Jan 08, 2023 at 09:19:22PM +0000, Matthew Wilcox wrote: > On Sun, Jan 08, 2023 at 05:56:42PM +0100, Christoph Hellwig wrote: > > We do not need to writeout modified directory blocks immediately when > > modifying them while the page is locked. It is enough to do the flush > > somewhat later which has the added benefit that inode times can be > > flushed as well. It also allows us to stop depending on > > write_one_page() function. > > Similar concerns to the minix patch here ... missing assignments to > 'err'. Fixed.