On Sun, Jan 8, 2023 at 10:59 PM Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Sun, Jan 08, 2023 at 08:40:32PM +0100, Andreas Gruenbacher wrote: > > Eliminate the ->iomap_valid() handler by switching to a ->get_folio() > > handler and validating the mapping there. > > > > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx> > > I think this is wrong. > > The ->iomap_valid() function handles a fundamental architectural > issue with cached iomaps: the iomap can become stale at any time > whilst it is in use by the iomap core code. > > The current problem it solves in the iomap_write_begin() path has to > do with writeback and memory reclaim races over unwritten extents, > but the general case is that we must be able to check the iomap > at any point in time to assess it's validity. > > Indeed, we also have this same "iomap valid check" functionality in the > writeback code as cached iomaps can become stale due to racing > writeback, truncated, etc. But you wouldn't know it by looking at the iomap > writeback code - this is currently hidden by XFS by embedding > the checks into the iomap writeback ->map_blocks function. > > That is, the first thing that xfs_map_blocks() does is check if the > cached iomap is valid, and if it is valid it returns immediately and > the iomap writeback code uses it without question. > > The reason that this is embedded like this is that the iomap did not > have a validity cookie field in it, and so the validity information > was wrapped around the outside of the iomap_writepage_ctx and the > filesystem has to decode it from that private wrapping structure. > > However, the validity information iin the structure wrapper is > indentical to the iomap validity cookie, Then could that part of the xfs code be converted to use iomap->validity_cookie so that struct iomap_writepage_ctx can be eliminated? > and so the direction I've > been working towards is to replace this implicit, hidden cached > iomap validity check with an explicit ->iomap_valid call and then > only call ->map_blocks if the validity check fails (or is not > implemented). > > I want to use the same code for all the iomap validity checks in all > the iomap core code - this is an iomap issue, the conditions where > we need to check for iomap validity are different for depending on > the iomap context being run, and the checks are not necessarily > dependent on first having locked a folio. > > Yes, the validity cookie needs to be decoded by the filesystem, but > that does not dictate where the validity checking needs to be done > by the iomap core. > > Hence I think removing ->iomap_valid is a big step backwards for the > iomap core code - the iomap core needs to be able to formally verify > the iomap is valid at any point in time, not just at the point in > time a folio in the page cache has been locked... We don't need to validate an iomap "at any time". It's two specific places in the code in which we need to check, and we're not going to end up with ten more such places tomorrow. I'd prefer to keep those filesystem internals in the filesystem specific code instead of exposing them to the iomap layer. But that's just me ... If we ignore this particular commit for now, do you have any objections to the patches in this series? If not, it would be great if we could add the other patches to iomap-for-next. By the way, I'm still not sure if gfs2 is affected by this whole iomap validation drama given that it neither implements unwritten extents nor delayed allocation. This is a mess. Thanks, Andreas
