On Wed, 4 Jan 2023 at 13:59, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > On Wed, Jan 04, 2023 at 11:53:56AM +0100, Miklos Szeredi wrote: > > Shouldn't the test ignore sgid without group execute instead? It's > > not a security issue and expecting a certain value is not going to > > help find real issues (e.g. in old distro kernels, where this test > > will now start failing). > > Yeah, I would be fine with just leaving the group-exec and all-exec > tests 10 and 12 and dropping tests 9 and 11. > > > > > Yeah, doing that is more involved, but I do believe that it would be > > the right way to go. > > Just asking so I'm not missing a subtlety you're thinking of: why would > this be more involved? Seems easier to me even. Leaving out 9 and 11 would be a good start. To be entirely consistent tests 1 and 3 would need to be modified to ignore the sgid bit in the result. That would be the involved part. Thanks, Miklos
