Re: [PATCH] selftests: Add missing <sys/syscall.h> to mount_setattr test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01 2022 at 20:32:18 +0530, Daan De Meyer wrote:
> Including <sys/syscall.h> is required to define __NR_mount_setattr
> and __NR_open_tree which the mount_setattr test relies on.
> 
> Signed-off-by: Daan De Meyer <daan.j.demeyer@xxxxxxxxx>
> ---
>  tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> index 8c5fea68ae67..da85f8af482c 100644
> --- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> +++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> @@ -11,6 +11,7 @@
>  #include <sys/wait.h>
>  #include <sys/vfs.h>
>  #include <sys/statvfs.h>
> +#include <sys/syscall.h>
>  #include <sys/sysinfo.h>
>  #include <stdlib.h>
>  #include <unistd.h>

Tested-by: Siddh Raman Pant <code@xxxxxxxx>

Though this oversight actually led to gcc detecting another
another error [1], as it entered the #ifndef __NR_mount_setattr
block.

Thanks,
Siddh

[1] https://lore.kernel.org/all/20221211092820.85527-1-code@xxxxxxxx/



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux