Hey Linus, /* Summary */ This moves the ima specific vfs{g,u}id_t comparison helpers out of the header and into the one file in ima where they are used. We shouldn't incentivize people to use them by placing them into the header. As discussed and suggested by Linus in [1] let's just define them locally in the one file in ima where they are used. Link: https://lore.kernel.org/lkml/CAHk-=wj+tqv2nyUZ5T5EwYWzDAAuhxQ+-DA2nC9yYOTUo5NOPg@xxxxxxxxxxxxxx [1] /* Testing */ clang: Ubuntu clang version 15.0.2-1 gcc: gcc (Ubuntu 12.2.0-3ubuntu1) 12.2.0 No build failures or warnings were observed. All old and new tests in fstests, selftests, and LTP pass without regressions. /* Conflicts */ At the time of creating this PR no merge conflicts were reported from linux-next and no merge conflicts showed up doing a test-merge with current mainline. The following changes since commit 764822972d64e7f3e6792278ecc7a3b3c81087cd: Merge tag 'nfsd-6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux (2022-12-12 20:54:39 -0800) are available in the Git repository at: ssh://git@xxxxxxxxxxxxxxxxxxx/pub/scm/linux/kernel/git/vfs/idmapping.git tags/fs.vfsuid.ima.v6.2-rc1 for you to fetch changes up to 2c05bf3aa0741f4f3c72432db7801371dbbcf289: mnt_idmapping: move ima-only helpers to ima (2022-12-13 12:28:51 +0100) Please consider pulling these changes from the signed fs.vfsuid.ima.v6.2-rc1 tag. Thanks! Christian ---------------------------------------------------------------- fs.vfsuid.ima.v6.2-rc1 ---------------------------------------------------------------- Christian Brauner (1): mnt_idmapping: move ima-only helpers to ima include/linux/mnt_idmapping.h | 20 -------------------- security/integrity/ima/ima_policy.c | 24 ++++++++++++++++++++++++ 2 files changed, 24 insertions(+), 20 deletions(-)