Re: [GIT PULL] Add support for epoll min wait time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jens,

On Sat, Dec 10, 2022 at 08:36:11AM -0700, Jens Axboe wrote:
> Hi Linus,
> 
> I've had this done for months and posted a few times, but little
> attention has been received.

I personally think this is particularly cool, for having faced the
same needs in the past. I'm just wondering how long we'll avoid the
need for marking certain FDs as urgent (i.e. for inter-thread wakeup)
which would bypass the min delay.

I'm just seeing something a bit odd in this series:

> ----------------------------------------------------------------
> epoll-min_ts-2022-12-08
> 
> ----------------------------------------------------------------
> Jens Axboe (8):
>       eventpoll: cleanup branches around sleeping for events
>       eventpoll: don't pass in 'timed_out' to ep_busy_loop()
>       eventpoll: split out wait handling
>       eventpoll: move expires to epoll_wq
>       eventpoll: move file checking earlier for epoll_ctl()
>       eventpoll: add support for min-wait
>       eventpoll: add method for configuring minimum wait on epoll context
>       eventpoll: ensure we pass back -EBADF for a bad file descriptor

This last patch fixes a bug introduced by the 5th one. Why not squash it
instead of purposely introducing a bug then its fix ? Or maybe it was
just overlooked when you sent the PR ?

Thanks,
Willy



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux