Re: [PATCH v3] fsverity: stop using PG_error to track error status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 10, 2022 at 12:21:06AM -0800, Eric Biggers wrote:
> On Fri, Oct 28, 2022 at 10:58:07AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> > 
> > As a step towards freeing the PG_error flag for other uses, change ext4
> > and f2fs to stop using PG_error to track verity errors.  Instead, if a
> > verity error occurs, just mark the whole bio as failed.  The coarser
> > granularity isn't really a problem since it isn't any worse than what
> > the block layer provides, and errors from a multi-page readahead aren't
> > reported to applications unless a single-page read fails too.
> > 
> > f2fs supports compression, which makes the f2fs changes a bit more
> > complicated than desired, but the basic premise still works.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> > ---
> > 
> > In v3, I made a small simplification to the f2fs changes.  I'm also only
> > sending the fsverity patch now, since the fscrypt one is now upstream.  
> > 
> >  fs/ext4/readpage.c |  8 ++----
> >  fs/f2fs/compress.c | 64 ++++++++++++++++++++++------------------------
> >  fs/f2fs/data.c     | 48 +++++++++++++++++++---------------
> >  fs/verity/verify.c | 12 ++++-----
> >  4 files changed, 67 insertions(+), 65 deletions(-)
> 
> I've applied this to the fsverity tree for 6.2.
> 
> Reviews would be greatly appreciated, of course.
> 

Jaegeuk and Chao, can I get a review or ack from one of you?

- Eric



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux